Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Controller.Watch() should not store watches if already started #1163

Merged

Commits on Sep 15, 2020

  1. 🐛 Controller.Watch() should not store watches if already started

    The controller internal struct holds a list of watches
    (as []watchDescription) when someone calls .Watch() to then start the
    watches and informers once we're ready to call Start().
    
    This behavior caused a memory leak in the case Watch was called after
    a controller has already been started and if the source.Kind's cache was
    either stopped or not available any longer. The leak was caused by the
    watches internal slice holding on to all references to each watch ever
    issued (and their respective caches).
    
    Signed-off-by: Vince Prignano <vincepri@vmware.com>
    vincepri committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    a6ec31f View commit details
    Browse the repository at this point in the history