-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Update dependencies to v0.19.2 #1170
Conversation
Signed-off-by: Vince Prignano <vincepri@vmware.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Hello, is this issue relevant again? Trying to update deps:
|
@george-angel The klog/klogr dependencies must match what's defined in controller-runtime |
Thanks @vincepri , I think the fault is my own, I tried updating to go 1.17 in my go.mod and I can see that controller-runtime is using 1.16. Let me debug further and raise an issue with more detail if I feel one actually exists. |
Signed-off-by: Vince Prignano vincepri@vmware.com
/assign @alvaroaleman @DirectXMan12
/milestone v0.7.x