Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Controller reconcileHandler shouldn't stop a worker on error #1196

Merged
merged 1 commit into from
Oct 1, 2020
Merged

🐛 Controller reconcileHandler shouldn't stop a worker on error #1196

merged 1 commit into from
Oct 1, 2020

Commits on Oct 1, 2020

  1. 🐛 Controller reconcileHandler shouldn't stop a worker on error 

    During a code walkthrough noticed that oddly the reconcileHandler was
returning false and stopping the worker entirely when an error is
returned from the reconciler. This change removes the return boolean
from reconcileHandler altogether and a worker is now only stopped when
the queue is shutdown.

Signed-off-by: Vince Prignano <vincepri@vmware.com>
    @vincepri
    vincepri committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    b4a0212 View commit details
    Browse the repository at this point in the history