🌱 Add ctrl.{LoggerFrom, LoggerInto} #1202
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the current (unreleased at the time of writing)
LoggerFromContext to LoggerFrom, and adds a new alias named LoggerInto.
From a user standpoint these new aliases are really clear and
straightfoward, example:
This reads much better than ctrl.LoggerFromContext(ctx) which repeats
the context.
Another use case that this change solves is to enrich the logger with
more values, example:
allows the ctx to still be the de-facto context, and the logger for the
inner reconciler function to still only accept ctx, without adding any
more parameters.
Signed-off-by: Vince Prignano vincepri@vmware.com
/milestone v0.7.x
/assign @DirectXMan12 @alvaroaleman