-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Tracker upgrade should use gvk from scheme #1213
🐛 Tracker upgrade should use gvk from scheme #1213
Conversation
lgtm pending Vince's suggestion and fixing the PR title to appease the checks. |
07a7a8c
to
87480a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/milestone v0.7.x |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@fabriziopandini Please fix the PR title cc @DirectXMan12 Not sure why the check isn't running anymore 🤔 |
/test pull-controller-runtime-test-master |
This PR makes sure
tracker.Upgrade
uses the gvk from scheme forAllowUnconditionalUpdate
andAllowCreateOnUpdate
in caseTypeMeta
is not defined on the objFixes: #1212