🐛 Ensure that webhook server is thread/start-safe #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the webhook server is both threadsafe & "start-safe" -- i.e. you can register webhooks after starting the server. While this is generally not a common pattern, be allow runnables to be added to the manager after start, so it makes sense to do the same with hooks & the server.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
adrianludwin
changed the title
|
/assign @vincepri |
|
Ping - can someone please approve this? Thanks! |
|
/assign @DirectXMan12 ? |
|
/milestone v0.6.x |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retitle 🐛 Ensure that webhook server is thread/start-safe |
k8s-ci-robot
changed the title
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, alvaroaleman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherrypick of #1155 into the v0.6 branch. I tested it by importing this (modified) branch into HNC and verifying that it solved the problem (kubernetes-retired/multi-tenancy#1127).
Fixed #1172.
The original description follows:
This ensures that the webhook server is both threadsafe & "start-safe"
-- i.e. you can register webhooks after starting the server. While this
is generally not a common pattern, be allow runnables to be added to the
manager after start, so it makes sense to do the same with hooks & the
server.