-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Improve docs for client.Object #1231
📖 Improve docs for client.Object #1231
Conversation
It was brought to my attention that the relationship between client.Object and runtime.Object isn't particularly clear to folks who are not used to working in the guts of client-go & apimachinery, so this adds some docs to helpfully clarify and provide examples.
cc @cflewis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, cflewis, DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@DirectXMan12 sidenote, do you think we should try to uptstream these two interfaces to make them a bit more official? |
It was brought to my attention that the relationship between
client.Object and runtime.Object isn't particularly clear to folks who
are not used to working in the guts of client-go & apimachinery, so this
adds some docs to helpfully clarify and provide examples.