Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add back error logging for Reconcile implementation #1245

Merged
merged 1 commit into from
Nov 9, 2020
Merged

🌱 Add back error logging for Reconcile implementation #1245

merged 1 commit into from
Nov 9, 2020

Commits on Nov 9, 2020

  1. Add back error logging for Reconcile implementation 

    This https://github.com/kubernetes-sigs/controller-runtime/pull/1054/files#diff-3f86588ef108e53ef346d3223ca106ccaa8efe72cb1055489665d7675f3da7b4R242 degaded the log level for the Reconcile implementation.

Then this completely remove the error logging https://github.com/kubernetes-sigs/controller-runtime/pull/1096/files#diff-3f86588ef108e53ef346d3223ca106ccaa8efe72cb1055489665d7675f3da7b4L242

When developing new controllers feels counterintuitive that controller runtime eats the error returned by the Reconcile implementation.

This proposes to log the error and let developers to create an additional log on the implementation if they choose to.
    @enxebre
    enxebre committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    eac2226 View commit details
    Browse the repository at this point in the history