-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ hack/setup-envtest.sh: install binaries and print export variable command #1258
✨ hack/setup-envtest.sh: install binaries and print export variable command #1258
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: estroz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @vincepri |
5049c99
to
7ca7d13
Compare
This should help fix problems like operator-framework/operator-sdk#4203 |
@estroz: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
Doesn't seem to be getting attention, and I think there was affirmative discussion of providing a library to download and/or look up envtest binaries rather than rely on the wrapping shell env. |
The current setup-envtest.sh script is a little clunky, since it contains a combination of global settings and functions, and your calling shell is expected to be bash. Instead, the script should only download the envtest binaries, then print what to do next (
export KUBEBUILDER_ASSETS=bin
). You can automatically do the next thing withBinaries are now installed into the argument directory directly instead of under
$1/bin
, which is more intuitive; the default is$PWD/bin
.