-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Specify buckets for "controller_runtime_reconcile_time_seconds" histogram metrics #1273
🌱 Specify buckets for "controller_runtime_reconcile_time_seconds" histogram metrics #1273
Conversation
…gram metrics Current metric uses Prometheus default bucket for reconcile time histogram. This bucket is not sufficient to reason about percentile of requests which take less than x seconds when x falls outside the bucket of 10 secs. It's also hard to infer when the reconcile loops are fairly fast, as mentioned in this issue: kubernetes-sigs#258. This PR attempts to define explicit buckets for the metrics, values are chosen based on the apiserver request latency defined here: https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go#L103. The default Prometheus histogram buckets has also been added(wherever missing) to ensure backward compatibility.
Welcome @irajdeep! |
Hi @irajdeep. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @vincepri
/retitle 🌱 Specify buckets for "controller_runtime_reconcile_time_seconds" histogram metrics |
/approve cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irajdeep, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The current metric uses Prometheus default bucket for reconcile time histogram. This bucket is
not sufficient to reason about the percentile of requests which take less than x seconds when x falls outside
the bucket of 10 secs(current last bucket). It's also hard to infer when the reconcile loops are fairly fast, as mentioned in
this issue: #258.
This PR attempts to define explicit buckets for the metrics, values are chosen based on the API-server
request latency defined here: https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go#L103.
The default Prometheus histogram buckets have also been added(wherever missing) to ensure backward compatibility.