✨ Add example for using apply client #1365

Jefftree · 2021-02-01T16:42:14Z

Example for using the server side apply client with CRDs

Took the suggestion of using the Patch to embed the applyconfiguration.

cl.Patch(context.TODO(), fooObj, client.ApplyFrom(applyConfig), owner);

where fooObj is the underlying type (to contain the returned patch object) and applyConfig is the applyconfiguration.

I'm not exactly sure how useful the applyconfig example is, let me know if you have any suggestions on how it can be improved. Thanks!

DirectXMan12 · 2021-02-24T23:35:13Z

/hold

(work in progress)

Jefftree · 2021-05-18T16:18:37Z

/retest

zoetrope · 2021-05-19T10:01:44Z

I'm not exactly sure how useful the applyconfig example is, let me know if you have any suggestions on how it can be improved. Thanks!

I believe the applyconfig is very useful for applying patch when CRD has fields like PodTemplate and ServiceTemplate.
My samples can be found below.
https://github.com/zoetrope/reconcile-tips/blob/typed-ssa/controllers/myapp_controller.go

However, controller-gen doesn't seem to be able to generate deepcopy of CRs including applyconfigs.
kubernetes-sigs/controller-tools#570

Do you have a good solution?

pkg/client/patch.go

k8s-triage-robot · 2022-03-06T19:43:57Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

joelanford · 2022-03-07T18:21:04Z

/lifecycle frozen

k8s-ci-robot · 2022-03-07T18:21:05Z

@joelanford: The lifecycle/frozen label cannot be applied to Pull Requests.

In response to this:

/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

joelanford · 2022-03-07T18:21:24Z

/remove-lifecycle stale

k8s-triage-robot · 2022-06-19T19:09:21Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

imheresamir · 2022-06-22T03:26:46Z

/remove-lifecycle stale

k8s-ci-robot · 2022-09-01T16:05:59Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jefftree
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval by writing /assign @vincepri in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-triage-robot · 2022-12-12T18:32:15Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2023-01-11T19:23:31Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2023-02-10T20:20:39Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2023-02-10T20:20:43Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cannonpalms · 2023-03-23T16:52:48Z

It'd be lovely if this were revived and merged! The SSA story in controller-runtime is woefully underdocumented. I believe this also removes the need to convert to unstructured? kubernetes-sigs/controller-tools#570 (comment)

cannonpalms · 2023-03-23T16:53:54Z

/reopen

k8s-ci-robot · 2023-03-23T16:53:57Z

@cannonpalms: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 1, 2021

Jefftree changed the title ~~✨ Add example for using apply client~~ :sparkles Add example for using apply client Feb 1, 2021

k8s-ci-robot requested review from shawn-hurley and vincepri February 1, 2021 16:42

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 1, 2021

Jefftree changed the title ~~:sparkles Add example for using apply client~~ ✨ Add example for using apply client Feb 1, 2021

Jefftree changed the title ~~✨ Add example for using apply client~~ ✨ Add example for using apply client [WIP] Feb 1, 2021

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2021

Jefftree force-pushed the apply-client branch 3 times, most recently from 84a0f28 to 036788c Compare May 18, 2021 01:02

Jefftree changed the title ~~✨ Add example for using apply client [WIP]~~ ✨ Add example for using apply client May 18, 2021

Jefftree force-pushed the apply-client branch 3 times, most recently from e59dc76 to 59d0129 Compare May 18, 2021 01:14

Jefftree force-pushed the apply-client branch 5 times, most recently from f498f93 to 9fa2a3c Compare May 18, 2021 21:47

zoetrope mentioned this pull request May 19, 2021

controller-gen feature request: support for generating DeepCopy of ApplyConfigrations kubernetes-sigs/controller-tools#570

Closed

cbandy reviewed May 24, 2021

View reviewed changes

pkg/client/patch.go Outdated Show resolved Hide resolved

jpbetz reviewed Jun 1, 2021

View reviewed changes

pkg/client/patch.go Outdated Show resolved Hide resolved

jpbetz reviewed Jun 1, 2021

View reviewed changes

pkg/client/patch.go Outdated Show resolved Hide resolved

pkg/client/patch.go Outdated Show resolved Hide resolved

Jefftree force-pushed the apply-client branch 3 times, most recently from 4c1a260 to 5744e92 Compare July 15, 2021 16:16

wmuizelaar mentioned this pull request Feb 24, 2022

Add Server Side Apply documentation to the book kubernetes-sigs/kubebuilder#2514

Open

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 6, 2022

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 7, 2022

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 19, 2022

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 22, 2022

Jefftree added 4 commits September 1, 2022 15:47

apply example

6820fbd

Feedback

720c095

Address comments

760a881

Rebase latest version

3a0b793

Jefftree force-pushed the apply-client branch from 5744e92 to 3a0b793 Compare September 1, 2022 16:05

Comments

ab9ceff

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 12, 2022

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 11, 2023

k8s-ci-robot closed this Feb 10, 2023

Jefftree mentioned this pull request Apr 7, 2023

Server-side Apply! #347

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Add example for using apply client #1365

✨ Add example for using apply client #1365

Jefftree commented Feb 1, 2021 •

edited

Loading

DirectXMan12 commented Feb 24, 2021

Jefftree commented May 18, 2021

zoetrope commented May 19, 2021 •

edited

Loading

k8s-triage-robot commented Mar 6, 2022

joelanford commented Mar 7, 2022

k8s-ci-robot commented Mar 7, 2022

joelanford commented Mar 7, 2022

k8s-triage-robot commented Jun 19, 2022

imheresamir commented Jun 22, 2022

k8s-ci-robot commented Sep 1, 2022

k8s-triage-robot commented Dec 12, 2022

k8s-triage-robot commented Jan 11, 2023

k8s-triage-robot commented Feb 10, 2023

k8s-ci-robot commented Feb 10, 2023

cannonpalms commented Mar 23, 2023 •

edited

Loading

cannonpalms commented Mar 23, 2023

k8s-ci-robot commented Mar 23, 2023

✨ Add example for using apply client #1365

✨ Add example for using apply client #1365

Conversation

Jefftree commented Feb 1, 2021 • edited Loading

DirectXMan12 commented Feb 24, 2021

Jefftree commented May 18, 2021

zoetrope commented May 19, 2021 • edited Loading

k8s-triage-robot commented Mar 6, 2022

joelanford commented Mar 7, 2022

k8s-ci-robot commented Mar 7, 2022

joelanford commented Mar 7, 2022

k8s-triage-robot commented Jun 19, 2022

imheresamir commented Jun 22, 2022

k8s-ci-robot commented Sep 1, 2022

k8s-triage-robot commented Dec 12, 2022

k8s-triage-robot commented Jan 11, 2023

k8s-triage-robot commented Feb 10, 2023

k8s-ci-robot commented Feb 10, 2023

cannonpalms commented Mar 23, 2023 • edited Loading

cannonpalms commented Mar 23, 2023

k8s-ci-robot commented Mar 23, 2023

Jefftree commented Feb 1, 2021 •

edited

Loading

zoetrope commented May 19, 2021 •

edited

Loading

cannonpalms commented Mar 23, 2023 •

edited

Loading