Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add Selector option to Builder #1425

Closed

Conversation

qinqon
Copy link
Contributor

@qinqon qinqon commented Mar 12, 2021

As a follow up of [1] this change instruct the ListWatcher from the
informers to select by label/field but instead of using a manager/cache
Options it pass the select using the builder.

[1] #1404

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 12, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @qinqon. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: qinqon
To complete the pull request process, please assign joelanford after the PR has been reviewed.
You can assign the PR to them by writing /assign @joelanford in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from droot March 12, 2021 14:50
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 12, 2021
@qinqon qinqon force-pushed the set-cache-selectors-at-builder branch 2 times, most recently from d1ef84b to a989021 Compare March 16, 2021 10:14
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 16, 2021
@qinqon qinqon force-pushed the set-cache-selectors-at-builder branch from a989021 to bd3fe13 Compare March 16, 2021 10:50
As a follow up of [1] this change instruct the ListWatcher from the
informers to select by label/field but instead of using a manager/cache
Options it pass the select using the builder.

[1] kubernetes-sigs#1404

Signed-off-by: Quique Llorente <ellorent@redhat.com>
@qinqon qinqon force-pushed the set-cache-selectors-at-builder branch from bd3fe13 to fb8b3cd Compare March 16, 2021 11:18
@qinqon qinqon changed the title Add Cache.SetSelector ✨ Add Selector option to Builder Mar 16, 2021
@qinqon qinqon marked this pull request as ready for review March 16, 2021 11:19
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 16, 2021
Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

The implication of "We do ignore the effects of this change to the client' is IMHO that we should not add any option other than overwriting the NewCacheFunc to get access to this functionality. Otherwise ppl will use this, not get their objects that do not match the selector via the client anymore and create support issues.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2021
@qinqon qinqon closed this Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants