-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add Selector option to Builder #1425
✨ Add Selector option to Builder #1425
Conversation
Hi @qinqon. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d1ef84b
to
a989021
Compare
a989021
to
bd3fe13
Compare
As a follow up of [1] this change instruct the ListWatcher from the informers to select by label/field but instead of using a manager/cache Options it pass the select using the builder. [1] kubernetes-sigs#1404 Signed-off-by: Quique Llorente <ellorent@redhat.com>
bd3fe13
to
fb8b3cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
The implication of "We do ignore the effects of this change to the client' is IMHO that we should not add any option other than overwriting the NewCacheFunc to get access to this functionality. Otherwise ppl will use this, not get their objects that do not match the selector via the client anymore and create support issues.
As a follow up of [1] this change instruct the ListWatcher from the
informers to select by label/field but instead of using a manager/cache
Options it pass the select using the builder.
[1] #1404