Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issues when running on master #145

Merged
merged 1 commit into from
Sep 17, 2018
Merged

fix issues when running on master #145

merged 1 commit into from
Sep 17, 2018

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Sep 17, 2018 •
edited
Loading

fix issues when using fs cert writer (the default one is secret writer):

  • non-443 port support in URL mode
  • ensure not port is in host name when gen the cert

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 17, 2018
@mengqiy mengqiy changed the title fix issues when using fs cert writer fix issues when running on master Sep 17, 2018
@mengqiy mengqiy removed the request for review from DirectXMan12 September 17, 2018 18:44
@Liujingfang1
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2018
@mengqiy mengqiy added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ad139d6 into kubernetes-sigs:master Sep 17, 2018
@mengqiy mengqiy deleted the fix_fs_cert_writer branch September 17, 2018 20:32
justinsb pushed a commit to justinsb/controller-runtime that referenced this pull request Dec 7, 2018
@k8s-ci-robot
Merge pull request kubernetes-sigs#145 from mengqiy/fix_fs_cert_writer
6dd9937 
fix issues when running on master
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
Merge pull request #145 from pwittrock/docs-gen
a5bc55b 
Update GitBook with new release number and clarification on docs gen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liujingfang1 Liujingfang1 Awaiting requested review from Liujingfang1

@droot droot Awaiting requested review from droot

Assignees

@Liujingfang1 Liujingfang1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mengqiy @Liujingfang1 @k8s-ci-robot