Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Event recorder should not send events when broadcaster is stopped #1451

Merged
merged 1 commit into from
Mar 24, 2021

Commits on Mar 24, 2021

  1. 🐛 Event recorder should not send events when broadcaster is stopped

    This change solves a race condition when the manager is shutting down
    and reconcilers are still in the process of sending events through the
    recorder. If the shutdown timeout is hit too early, the event recorder
    panics because we're still trying to send events through the recorder.
    
    To avoid this issue, we introduce a RWMutex between the provider and
    event recorder. When the broadcaster is shutdown, events are now
    dropped.
    
    Signed-off-by: Vince Prignano <vincepri@vmware.com>
    vincepri committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    f89fe47 View commit details
    Browse the repository at this point in the history