Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Clean up pkg/internal/testing #1540

Merged
merged 5 commits into from
May 26, 2021
Merged

✨ Clean up pkg/internal/testing #1540

merged 5 commits into from
May 26, 2021

Commits on May 25, 2021

  1. Split up testing/integration/internal 

    This moves testing/integration/internal into several more specific
packages to prepare to refactor the rest and dedup with the main envtest
code.
    @DirectXMan12
    DirectXMan12 committed May 25, 2021
    Configuration menu
    Copy the full SHA
    8622835 View commit details
    Browse the repository at this point in the history

  2. Testing move control plane components 

    This moves control plane components to a new internal/testing/controlplane
directory, unifying the first and second levels of internal packages.
    @DirectXMan12
    DirectXMan12 committed May 25, 2021
    Configuration menu
    Copy the full SHA
    9ed51aa View commit details
    Browse the repository at this point in the history

  3. Testing: Remove legacy cruft from process 

    This removes some legacy cruft from the process abstraction, namely:

- the legacy health check support (startup message), since our supported
  etcd versions support the /health endpoint

- URL populatation, since we end up needing multiple ports for the api
  server

- gexec usage, since we don't need to check wait messages any more
  and the equivalent "send SIGTERM" and "wait for process to exit"
  parts are pretty straightforward for our usecases.
    @DirectXMan12
    DirectXMan12 committed May 25, 2021
    Configuration menu
    Copy the full SHA
    c56312c View commit details
    Browse the repository at this point in the history

  4. Remove last of pkg/internal/testing/integration 

    This only contained integration tests, which will be re-introduced in a
cleaned up form shortly.
    @DirectXMan12
    DirectXMan12 committed May 25, 2021
    Configuration menu
    Copy the full SHA
    9d53bf1 View commit details
    Browse the repository at this point in the history

  5. Update to use new internal/testing paths 

    This updates envtests, etc to use to the new refactored
internal/testing/xyz paths (certs, addr, controlplane).
    @DirectXMan12
    DirectXMan12 committed May 25, 2021
    Configuration menu
    Copy the full SHA
    294af4f View commit details
    Browse the repository at this point in the history