Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set path in builder #156

Merged
merged 1 commit into from
Sep 21, 2018
Merged

set path in builder #156

merged 1 commit into from
Sep 21, 2018

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Sep 21, 2018

Fix a bug.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 21, 2018
@mengqiy mengqiy requested review from droot and Liujingfang1 and removed request for DirectXMan12 and pwittrock September 21, 2018 04:35
@droot droot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 21, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d2963e0 into kubernetes-sigs:master Sep 21, 2018
@mengqiy mengqiy deleted the set_path branch September 21, 2018 17:12
justinsb pushed a commit to justinsb/controller-runtime that referenced this pull request Dec 7, 2018
@k8s-ci-robot
Merge pull request kubernetes-sigs#156 from mengqiy/set_path
c4ede5c 
set path in builder
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
Merge pull request #156 from fanzhangio/doc-annotation
fbeb436 
Add annotation support for generating doc config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot Awaiting requested review from droot

@Liujingfang1 Liujingfang1 Awaiting requested review from Liujingfang1

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mengqiy @k8s-ci-robot @droot