-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 tmp-logging - fix markdown parsing error #1584
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @maxg-teachable! |
Hi @maxg-teachable. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
@maxg-teachable please sign the CLA as instructed by the bot: #1584 (comment) |
hey @alvaroaleman , the org I work for has completed the corporate sign up process , signed the CLA, and added me to their Linux Foundation organization 👍 |
i signed it |
@maxg-teachable unfortunately the automation doesn't agree on that. Have you signed it with the same email as you use for your git commit ( |
sorry for the confusion, that was me trying to kick the automation to re-check (found that here) 😓 The CLA was signed by the corporate rep of my org (following this doc) and I was added do that group. Do I also have to sign the CLA as an individual? |
Supposively no. To my knowledge the verification matches the email of the github commit to the email the CLA was signed with so I would assume that you have to use your corporate email for the commit rather than the |
ah, so we can't use github's email privacy feature , good to know, thanks for the explanation! I'll disable it and amend the author of the commit |
one back-tick was missing, causing the information about log levels to be rendered incorrectly
/check-cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, maxg-teachable, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
there was a missing back-tick in the logging-level section of
TMP-LOGGING.md
, causing the information about log levels to be rendered incorrectly