Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 tmp-logging - fix markdown parsing error #1584

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

maxg-teachable
Copy link
Contributor

there was a missing back-tick in the logging-level section of TMP-LOGGING.md, causing the information about log levels to be rendered incorrectly

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 8, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @maxg-teachable!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @maxg-teachable. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 8, 2021
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 8, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2021
@alvaroaleman
Copy link
Member

@maxg-teachable please sign the CLA as instructed by the bot: #1584 (comment)

@maxg-teachable
Copy link
Contributor Author

hey @alvaroaleman , the org I work for has completed the corporate sign up process , signed the CLA, and added me to their Linux Foundation organization 👍

@maxg-teachable
Copy link
Contributor Author

i signed it

@alvaroaleman
Copy link
Member

alvaroaleman commented Jul 9, 2021

i signed it

@maxg-teachable unfortunately the automation doesn't agree on that. Have you signed it with the same email as you use for your git commit (84244139+maxg-teachable@users.noreply.github.com)?

@maxg-teachable
Copy link
Contributor Author

@maxg-teachable unfortunately the automation doesn't agree on that. Have you signed it with the same email as you use for your git commit (84244139+maxg-teachable@users.noreply.github.com)?

sorry for the confusion, that was me trying to kick the automation to re-check (found that here) 😓

The CLA was signed by the corporate rep of my org (following this doc) and I was added do that group. Do I also have to sign the CLA as an individual?

@alvaroaleman
Copy link
Member

Do I also have to sign the CLA as an individual?

Supposively no. To my knowledge the verification matches the email of the github commit to the email the CLA was signed with so I would assume that you have to use your corporate email for the commit rather than the users.noreply.github.com one.

@maxg-teachable
Copy link
Contributor Author

Supposively no. To my knowledge the verification matches the email of the github commit to the email the CLA was signed with so I would assume that you have to use your corporate email for the commit rather than the users.noreply.github.com one.

ah, so we can't use github's email privacy feature , good to know, thanks for the explanation! I'll disable it and amend the author of the commit

one back-tick was missing, causing the information about log levels to be rendered incorrectly
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2021
@maxg-teachable
Copy link
Contributor Author

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 9, 2021
Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, maxg-teachable, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5a2de70 into kubernetes-sigs:master Jul 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.10.x milestone Jul 9, 2021
@maxg-teachable maxg-teachable deleted the patch-1 branch July 9, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants