🐛 Envtest should try to allocate a port for etcd listenPeerURL #1612
Conversation
Signed-off-by: Vince Prignano <vincepri@vmware.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
| @@ -150,7 +167,7 @@ func (e *Etcd) Stop() error { | |||
|
|
|||
| func (e *Etcd) defaultArgs() map[string][]string { | |||
| args := map[string][]string{ | |||
| "listen-peer-urls": {"http://localhost:0"}, | |||
| "listen-peer-urls": {e.listenPeerURL.String()}, | |||
There was a problem hiding this comment.
What difference does this make? Shouldn't etcd get a free port from the kernel (and then our allocation not consider that one)?
There was a problem hiding this comment.
If there are multiple parallel packages running at the same time, process A could internally allocate a port (on file) which is then used for either etcd listen or api-server, while process B (etcd) is already listening on it.
There is always a race condition between the code that allocates the port and the actual program startup, because the port gets closed right after we have a file lock, another program not knowing about the file allocation can snatch it.
There was a problem hiding this comment.
Makes sense, thanks for the explanation.
/lgtm
/approve
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Vince Prignano vincepri@vmware.com