-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Construct the typed clients we need #1637
Construct the typed clients we need #1637
Conversation
5ea04d6
to
375cfae
Compare
The pattern of constructing all the clients to get a kubernetes.Interface, only to extract one or two typed clients has the side-effect of importing a lot of packages that are otherwise unneeded. Avoid doing so by constructing the clients we need. This isn't sufficient to remove all these extra dependencies (because of the use of scheme.Scheme as default), but it is a step closer.
375cfae
to
a9d5651
Compare
@@ -24,8 +24,7 @@ import ( | |||
"github.com/go-logr/logr" | |||
corev1 "k8s.io/api/core/v1" | |||
"k8s.io/apimachinery/pkg/runtime" | |||
"k8s.io/client-go/kubernetes" | |||
typedcorev1 "k8s.io/client-go/kubernetes/typed/core/v1" | |||
corev1client "k8s.io/client-go/kubernetes/typed/core/v1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can keep the name: typedcorev1
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✨ Construct typed clients directly
The pattern of constructing all the clients to get a
kubernetes.Interface, only to extract one or two typed clients has the
side-effect of importing a lot of packages that are otherwise
unneeded.
Avoid doing so by constructing the clients we need.
This isn't sufficient to remove all these extra dependencies (because
of the use of scheme.Scheme as default), but it is a step closer.