Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Client: Ensure no stale data remains in target object #1640

Merged
merged 1 commit into from
Aug 26, 2021

Commits on Aug 22, 2021

  1. 🐛 Client: Ensure no stale data remains in target object

    Fixes kubernetes-sigs#1639
    
    The json deserializer of the stdlib and the one from Kube which aims to
    be compatible won't zero out all field types in the object it
    deserializes into, for example it lets slices be if the json does not
    contain that field. This means that if a non-empty variable is used for
    any api call with the client, the resulting content might be a mixture
    of previous content and what is on the server.
    
    This PR adds a wrapper around the deserializer that will first zero the
    target object.
    alvaroaleman committed Aug 22, 2021
    Configuration menu
    Copy the full SHA
    8ecdef0 View commit details
    Browse the repository at this point in the history