🌱 Manager should use the global logger, reduce log names verbosity #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently a controller using the default logger has very verbose names such as "controller-runtime/manager/controller/<name>", this changeset reduces the verbosity of each log line to mostly have controller/<name>. Signed-off-by: Vince Prignano <vincepri@vmware.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
alvaroaleman
approved these changes
Aug 27, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sbueringer
pushed a commit
to sbueringer/controller-runtime
that referenced
this pull request
Aug 27, 2021
…ernetes-sigs#1647) Currently a controller using the default logger has very verbose names such as "controller-runtime/manager/controller/<name>", this changeset reduces the verbosity of each log line to mostly have controller/<name>. Signed-off-by: Vince Prignano <vincepri@vmware.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a controller using the default logger has very verbose names
such as "controller-runtime/manager/controller/", this changeset
reduces the verbosity of each log line to mostly have controller/.
Signed-off-by: Vince Prignano vincepri@vmware.com