Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.9] ⚠️ Client: Ensure no stale data remains in target object #1661

Closed
wants to merge 1 commit into from
Closed

[release-0.9] ⚠️ Client: Ensure no stale data remains in target object #1661

wants to merge 1 commit into from

Commits on Sep 10, 2021

  1. bug: Client: Ensure no stale data remains in target object 

    Fixes kubernetes-sigs#1639

The json deserializer of the stdlib and the one from Kube which aims to
be compatible won't zero out all field types in the object it
deserializes into, for example it lets slices be if the json does not
contain that field. This means that if a non-empty variable is used for
any api call with the client, the resulting content might be a mixture
of previous content and what is on the server.

This PR adds a wrapper around the deserializer that will first zero the
target object.
    @alvaroaleman
    alvaroaleman authored and k8s-infra-cherrypick-robot committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    99ab43a View commit details
    Browse the repository at this point in the history