🐛 Fakeclient: Allow manipulating registered types through unstructured #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, manipulating an object that is registered through unstructured will break all subsequent List requests that include said object. This happens because the tracker unconditionally saves objects but it's List() assumes that what it finds can be assigned to the .Items slice of an object produced through scheme.New(ListGVK).
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/approve |
|
@joelanford was it intended to not lgtm the change and only approve? |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, joelanford, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
l-qing
added a commit
to katanomi/pkg
that referenced
this pull request
Jan 5, 2022
This logic can be removed after upgrading to controller-runtime v0.10.1 Ref: kubernetes-sigs/controller-runtime#1662
l-qing
added a commit
to katanomi/pkg
that referenced
this pull request
Jan 5, 2022
This logic can be removed after upgrading to controller-runtime v0.10.1 Ref: kubernetes-sigs/controller-runtime#1662 Co-authored-by: qingliu <qingliu@alauda.io>
5 tasks
|
Hello, thanks for the fix :) I need to upgrade my packages to get this fix -- which version/package is this fixed in? I'm currently using: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, manipulating an object that is registered through
unstructured will break all subsequent List requests that include said
object. This happens because the tracker unconditionally saves objects but
it's List() assumes that what it finds can be assigned to the .Items slice
of an object produced through scheme.New(ListGVK).
Fixes #1511
/assign @vincepri @joelanford