-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Unconditionally set NegotiatedSerializer #1664
🐛 Unconditionally set NegotiatedSerializer #1664
Conversation
We currently only set the NegotiatedSerializer when there is none set yet. Unfortunately, various things will break if someone sets their own in the rest config, hence always set it.
} else { | ||
cfg.NegotiatedSerializer = serializerWithTargetZeroingDecode{NegotiatedSerializer: serializer.WithoutConversionCodecFactory{CodecFactory: codecs}} | ||
} | ||
if isUnstructured { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not entirely sure if we should mark this at breaking. It is bu tut then again things are unlikely to have worked if anyone set this before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that we copy the config already so we won't manipulate the original one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @vincepri @alvaroaleman can we cherry-pick this fix back to v0.9.x? We have encountered this problem with v0.9.x version, but currently we cannot directly upgrade to v.0.10.x. |
We currently only set the NegotiatedSerializer when there is none set
yet. Unfortunately, various things will break if someone sets their own
in the rest config, hence always set it.
Fixes #1654