-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Allow Specification of the Log Timestamp Format #1688
🌱 Allow Specification of the Log Timestamp Format #1688
Conversation
Welcome @creydr! |
Hi @creydr. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
16b8425
to
32727e6
Compare
32727e6
to
395799e
Compare
395799e
to
7d14525
Compare
/retest |
Adds the --zap-time-encoding flag to specify the output format of the log timestamp. Allows: epoch (floating-point number of seconds since the Unix epoch), nanos (integer of nanoseconds since the Unix epoch), millis (floating-point number of milliseconds since the Unix epoch), iso8601 (ISO8601-formatted string with millisecond precision), rfc3339 (RFC3339-formatted string) and rfc3339nano (RFC3339-formatted string with nanosecond precision). Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
7d14525
to
5bb6cb7
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, creydr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@alvaroaleman Thanks for your patience. |
Currently the user doesn't have an option to specify the encoding of the log timestamps via a command line flag. So by default all log timestamps are in
epoch
format, which makes them hard to read/interpret imho.This PR addresses it and adds the
zap-time-encoding
flag, which allows to specify the required format for log timestamp encoding and accepts the following values:epoch
: floating-point number of seconds since the Unix epochnanos
: integer of nanoseconds since the Unix epochmillis
: floating-point number of milliseconds since the Unix epochiso8601
: ISO8601-formatted string with millisecond precisionrfc3339
: RFC3339-formatted string orrfc3339nano
: RFC3339-formatted string with nanosecond precision.