Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Bump to gomega v1.17.0, sync/fix some other dependencies #1713

Closed

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Nov 10, 2021

Signed-off-by: Stefan Büringer buringerst@vmware.com

Bumps dependencies. Especially setup-envtest is important as otherwise it isn't compatible with dependencies of the main go.mod (log dependencies).

Alternatively, we can merge #1714 (which is the same + alpha4/Go1.17)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sbueringer
To complete the pull request process, please assign pwittrock after the PR has been reviewed.
You can assign the PR to them by writing /assign @pwittrock in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -3,25 +3,25 @@ module sigs.k8s.io/controller-runtime
go 1.16

require (
github.com/evanphx/json-patch v5.6.0+incompatible
github.com/evanphx/json-patch v4.12.0+incompatible
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now sync with k/k (note: code should be the same as the previous tag as the real v5 is under the /v5 import path)

@sbueringer sbueringer changed the title ✨ Bump to k8s v1.23-alpha.4, gomega v1.17.0 [WIP] ✨ Bump to k8s v1.23-alpha.4, gomega v1.17.0 Nov 10, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2021
Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer sbueringer changed the title [WIP] ✨ Bump to k8s v1.23-alpha.4, gomega v1.17.0 [WIP] ✨ Bump to gomega v1.17.0, sync some other dependencies Nov 10, 2021
@sbueringer sbueringer changed the title [WIP] ✨ Bump to gomega v1.17.0, sync some other dependencies [WIP] ✨ Bump to gomega v1.17.0, sync/fix some other dependencies Nov 10, 2021
@sbueringer sbueringer changed the title [WIP] ✨ Bump to gomega v1.17.0, sync/fix some other dependencies ✨ Bump to gomega v1.17.0, sync/fix some other dependencies Nov 10, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2021
@vincepri
Copy link
Member

/lgtm
/assign @alvaroaleman

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2021
@sbueringer
Copy link
Member Author

/hold
Let's give alpha4 with Go 1.17 a try

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2021
@sbueringer
Copy link
Member Author

sbueringer commented Nov 10, 2021

/hold Let's give alpha4 with Go 1.17 a try

/hold cancel

or not

xref: https://kubernetes.slack.com/archives/C8TSNPY4T/p1636569429464100?thread_ts=1636568408.457200&cid=C8TSNPY4T

(will do another round with alpha4)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2021
@sbueringer
Copy link
Member Author

/hold
Looks like we'll just merge #1714 instead
xref: https://kubernetes.slack.com/archives/CAR30FCJZ/p1636571926243100

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2021
@sbueringer
Copy link
Member Author

/close
in favor of #1714

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closed this PR.

In response to this:

/close
in favor of #1714

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants