Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Correctly pass cache options on #1743

Merged
merged 1 commit into from
Dec 8, 2021

Commits on Dec 8, 2021

  1. 🐛 Correctly pass cache options on

    There were two bugs in this:
    * The caches `BuilderWithOptions` defaulted the opts it got from the
      manager with the ones it explicitly got, resulting in new fields
      like `DefaultSelector` needing to explicitly be added there
    * The caches `DefaultSelector` wasn't correctly used everywhere, because
      there was code left that directly accessed the gvk -> selector map and
      thus didn't get the default selector. Use a getter func rather than
      the map internally, to make this impossible
    alvaroaleman committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    558ef2e View commit details
    Browse the repository at this point in the history