Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 update links to godoc.org to use pkg.go.dev #1756

Merged
merged 2 commits into from
Jan 12, 2022

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Dec 27, 2021

Links to godoc.org seem to unconditionally and permanently redirect to pkg.go.dev nowadays:

$ curl -I https://godoc.org/github.com/go-logr/logr
HTTP/2 301
date: Mon, 27 Dec 2021 18:53:05 GMT
content-type: text/html; charset=utf-8
location: https://pkg.go.dev/github.com/go-logr/logr?utm_source=godoc
x-cloud-trace-context: 22d12027c3a1e74c4ccb40ccfc47d4cb/10602237531594422575;o=1
via: 1.1 google

This PR therefore changes the links to pkg.go.dev. I also noticed one typo and then looked and found a couple of other places where it's and its were mixed up.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 27, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @xrstf. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 27, 2021
@xrstf xrstf changed the title 📖 update links to godoc.org to use pkg.go.dev WIP - 📖 update links to godoc.org to use pkg.go.dev Dec 27, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 27, 2021
@xrstf xrstf changed the title WIP - 📖 update links to godoc.org to use pkg.go.dev 📖 update links to godoc.org to use pkg.go.dev Dec 27, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 27, 2021
@FillZpp
Copy link
Contributor

FillZpp commented Dec 28, 2021

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 28, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 28, 2021
@xrstf
Copy link
Contributor Author

xrstf commented Dec 28, 2021

/assign @pwittrock

@alvaroaleman alvaroaleman added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit b8db76e into kubernetes-sigs:master Jan 12, 2022
@k8s-ci-robot k8s-ci-robot added this to the v0.10.x milestone Jan 12, 2022
@xrstf xrstf deleted the fix-typos branch January 13, 2022 14:28
fabianvf pushed a commit to fabianvf/controller-runtime that referenced this pull request May 25, 2022
fabianvf pushed a commit to fabianvf/controller-runtime that referenced this pull request May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants