Refactor leader election in manager.Start #176
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion and comments from @droot in #163, I've refactored the leader election and controller manager
Start
to make it a little easier to read and remove the doubleselect
blocks that I had added.I've also taken the liberty of removing the leader electors stop channel from the equation, we don't particularly need it and this should make it easier to upgrade in the future (client-go 9 has a different signature for
OnStartedLeading
).