-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰 Inject func in predicate.{And,Or}
#1781
Conversation
Hi @timebertt. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
@rfranzke: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@vincepri @alvaroaleman I would appreciate some feedback on this PR. Kindly take a look, when you find time :) |
/approve Thanks for the fix @timebertt! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelanford, rfranzke, timebertt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pass down injector in
predicate.{And,Or}
to sub-predicates.I'm aware, that the injection mechanisms are deprecated.
However, it comes as a surprise to users that
And,Or
don't pass down the injector. Hence, I'm opening this PR to discuss fixing this unexpected behavior.