✨ Support multiple field selectors

[tamalsaha]

Signed-off-by: Tamal Saha tamal@appscode.com

[k8s-ci-robot]

Hi @tamalsaha. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tamalsaha
To complete the pull request process, please assign mengqiy after the PR has been reviewed.
You can assign the PR to them by writing /assign @mengqiy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[FillZpp]

Emm.. I don't think we can support this by listing objects multiple times. You have to know that the indexer always keep changing, which means the objects might be modified between the multiple lists.

For example, when user list with field selectors {"field1": "a", "field2": "b"}, he/she wants to get objects that match the two requirements. But there may be an object that previously have {"field1": "a", "field2": "y"} so it is returned by your first list with field1 index. And then someone updates it to be {"field1": "x", "field2": "b"}, so it is also returned by your second list with field2 index.

In this way, you will return the object to user, but the problem is that it has never matched the two requirements at the same time.

[tamalsaha]

Thanks @FillZpp ! I have added checks for generation. Now, we can be sure that the result for the all indices are for the same object.

[weilaaa]

Hi, there. I wanna add a complicated index into thread safe store. If it will be accepted, it helps here.

Related issues and pr

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[tamalsaha]

/remove-lifecycle stale

[k8s-ci-robot]

@tamalsaha: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[vincepri]

Closing due to inactivity, @tamalsaha please feel free to reopen once ready

/close

[k8s-ci-robot]

@vincepri: Closed this PR.

In response to this:

Closing due to inactivity, @tamalsaha please feel free to reopen once ready

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.