-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Log all errors from cache.GetInformer call #1858
Conversation
Currently, `kind.Start` prints the last error from the polling process, except for the NoKindMatchError. This behavior makes it users hard to debug the cause of the `getInformer` call failure since it always returns the context timeout error, which is the last error while polling. This commit logs all returned errors while calling `getInformer` in the polling process. Signed-off-by: Sunghoon Kang <hoon@linecorp.com>
Welcome @devholic! |
Hi @devholic. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, devholic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Currently,
kind.Start
prints the last error from the polling process, except for the NoKindMatchError.This behavior makes it users hard to debug the cause (e.g. forgot to add types to the scheme) of the
getInformer
call failure since it always returns the context timeout error, which is the last error while polling.This commit logs all returned errors while calling
getInformer
in the polling process.Signed-off-by: Sunghoon Kang hoon@linecorp.com