Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Improve the fake client builder with WithObjectTracker option #1863

Merged

Conversation

Waynegates
Copy link
Contributor

This pr improves the fake client with WithObjectTracker option.
This is useful when users want to set up unit tests across different fake client.
For example, when users are testing with client-go and kubebuilder, users will create a fake clientSet and a fake client.
Users can get the object tracker from the fake clientSet and set it to the fake controller-runtime client by this new option to let them share the same fake resources.
This will allow users to write more unit tests.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 11, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 11, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @Waynegates!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @Waynegates. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 11, 2022
@Waynegates
Copy link
Contributor Author

/assign @mengqiy

@Waynegates
Copy link
Contributor Author

Reference to a related issue. #1458

@sriram-anyscale
Copy link

Thanks for doing this. Looks good.

@alvaroaleman
Copy link
Member

@Waynegates thanks for your contribution. In order for us to be able to accept it, you need to sign the CLA as pointed out by the bot: #1863 (comment)

/cc @sbueringer
WDYT? Approach seems good to me

Also, please add tests for this.

@Waynegates
Copy link
Contributor Author

Waynegates commented Apr 14, 2022 via email

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 15, 2022
@Waynegates
Copy link
Contributor Author

@Waynegates thanks for your contribution. In order for us to be able to accept it, you need to sign the CLA as pointed out by the bot: #1863 (comment)

/cc @sbueringer WDYT? Approach seems good to me

Also, please add tests for this.

I have added the unit test. And I have requested to create a EasyCLA manager for my company Anyscale to let me pass the CLA Authorization.
Thanks.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 19, 2022
@Waynegates
Copy link
Contributor Author

@alvaroaleman @mengqiy @pwittrock @vincepri @sbueringer
I have got EasyCLA approved, added unit tests and check my PR.
Could any of you help to review the PR? Thanks!

@alvaroaleman alvaroaleman added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 23, 2022
Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, Waynegates

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit b1e1a4f into kubernetes-sigs:master Apr 23, 2022
@k8s-ci-robot k8s-ci-robot added this to the v0.10.x milestone Apr 23, 2022
@sbueringer
Copy link
Member

sbueringer commented Apr 26, 2022

/cc @sbueringer WDYT? Approach seems good to me

Back from PTO, looks good to me too. (and solves my issue #1458)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants