-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Improve the fake client builder with WithObjectTracker option #1863
✨ Improve the fake client builder with WithObjectTracker option #1863
Conversation
Welcome @Waynegates! |
Hi @Waynegates. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @mengqiy |
Reference to a related issue. #1458 |
Thanks for doing this. Looks good. |
@Waynegates thanks for your contribution. In order for us to be able to accept it, you need to sign the CLA as pointed out by the bot: #1863 (comment) /cc @sbueringer Also, please add tests for this. |
Thanks. I will ask for CLA and add tests.
Best wishes!
-------------------------------------------------------------------
Bruce Zhang
Uber Technology, CA, US
Alvaro Aleman ***@***.***> 于2022年4月14日周四 13:38写道:
… @Waynegates <https://github.com/Waynegates> thanks for your contribution.
In order for us to be able to accept it, you need to sign the CLA as
pointed out by the bot: #1863 (comment)
<#1863 (comment)>
/cc @sbueringer <https://github.com/sbueringer>
WDYT? Approach seems good to me
Also, please add tests for this.
—
Reply to this email directly, view it on GitHub
<#1863 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABN5D7ERCAPQGEHKKT2QWL3VFB63NANCNFSM5TB65BOQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I have added the unit test. And I have requested to create a EasyCLA manager for my company Anyscale to let me pass the CLA Authorization. |
@alvaroaleman @mengqiy @pwittrock @vincepri @sbueringer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, Waynegates The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Back from PTO, looks good to me too. (and solves my issue #1458) |
This pr improves the fake client with
WithObjectTracker
option.This is useful when users want to set up unit tests across different fake client.
For example, when users are testing with client-go and kubebuilder, users will create a fake clientSet and a fake client.
Users can get the object tracker from the fake clientSet and set it to the fake controller-runtime client by this new option to let them share the same fake resources.
This will allow users to write more unit tests.