-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ update client-go to 1.24-beta #1864
Conversation
Yes, all of them need to be updated together. |
f22fc9b
to
9a74c98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
@alexzielenski can you rebase please? I fixed the lint check in #1868, however gh actions does not appear to actually merge the code from the PR onto the basebranch prior to running the tests, so it doesn't pick that fix up :( |
9a74c98
to
545285a
Compare
545285a
to
3047bf4
Compare
@alexzielenski: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexzielenski, alvaroaleman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR was originally split off from #1805
Updates client-go and its dependencies to k8s 1.24-beta as well as fixes up a test which used removed API.
Please advise: There are a few k8s dependencies not included in this update such as k8s.io/apiextensions-apiserver , k8s.io/component-base. I am unsure if the procedure for updating one aspect of k8s requires updating all of it at once.