Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes logic that checks for a "port already in use" error #189

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Removes logic that checks for a "port already in use" error #189

merged 1 commit into from
Nov 1, 2018

Commits on Oct 31, 2018

  1. Removes logic that checks for a "port already in use" error and instead 

    retries on any error. The "port already in use" error is only present in
the stderr logs of the separate process (etcd or apiserver) and will
not be surfaced in the go error.

Checking the stderr logs is an alternative solution, but it's
fragile (the message could change in the future and varies across
operating systems).
    @mjnichol2
    mjnichol2 committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    a5c1704 View commit details
    Browse the repository at this point in the history