Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Bump dependencies #1937

Merged

Conversation

friedrichwilken
Copy link
Contributor

@friedrichwilken friedrichwilken commented Jun 22, 2022

This is a bump of all outdated dependencies but the k8s.io packages (there is another PR for that).

The goal of this PR is to prevent potential security vulnerabilities and increase performance.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 22, 2022
@k8s-ci-robot k8s-ci-robot requested a review from gerred June 22, 2022 10:18
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 22, 2022
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit

go.mod Outdated
github.com/go-logr/logr v1.2.0
github.com/go-logr/zapr v1.2.0
github.com/google/go-cmp v0.5.5
github.com/evanphx/json-patch v5.6.0+incompatible
Copy link
Member

@sbueringer sbueringer Jun 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
github.com/evanphx/json-patch v5.6.0+incompatible
github.com/evanphx/json-patch/v5 v5.6.0

I think you have to import it like this. They started using module path correctly with one of the latest releases IIRC (+ update the imports accordingly)

xrefs:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I wasn't aware. I added a commit. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had this issue in CAPI when bumping. I think otherwise you will end up with the code in the root folder of the repo which is afaik some v4 version :)

@sbueringer
Copy link
Member

Thx!
not sure what the considerations in this repo are for squashing the commits (or if Prow is run in merge-mode), but apart from that
/lgtm
from my side

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2022
@FillZpp
Copy link
Contributor

FillZpp commented Jun 23, 2022

/label tide/merge-method-squash

/lgtm

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, FriedrichWilken

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit a550f29 into kubernetes-sigs:master Jun 23, 2022
@k8s-ci-robot k8s-ci-robot added this to the v0.10.x milestone Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants