-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Bump dependencies #1937
✨ Bump dependencies #1937
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit
go.mod
Outdated
github.com/go-logr/logr v1.2.0 | ||
github.com/go-logr/zapr v1.2.0 | ||
github.com/google/go-cmp v0.5.5 | ||
github.com/evanphx/json-patch v5.6.0+incompatible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github.com/evanphx/json-patch v5.6.0+incompatible | |
github.com/evanphx/json-patch/v5 v5.6.0 |
I think you have to import it like this. They started using module path correctly with one of the latest releases IIRC (+ update the imports accordingly)
xrefs:
- https://github.com/evanphx/json-patch/releases/tag/v5.0.0
go get -u github.com/evanphx/json-patch/v5
(https://github.com/evanphx/json-patch#get-it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I wasn't aware. I added a commit. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had this issue in CAPI when bumping. I think otherwise you will end up with the code in the root folder of the repo which is afaik some v4 version :)
Thx! |
/label tide/merge-method-squash /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, FriedrichWilken The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is a bump of all outdated dependencies but the k8s.io packages (there is another PR for that).
The goal of this PR is to prevent potential security vulnerabilities and increase performance.