-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Do not mutate the global warning handler #1944
⚠️ Do not mutate the global warning handler #1944
Conversation
Only configure the local warning handler.
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the discussion in #1928, the fix seems reasonable.
/lgtm
@ash2k the change seems fine but can you please mark it as breaking, since that is what it is now, for better or worse? |
@alvaroaleman Changed the title if that was what you meant (not sure). Thanks for a quick review, appreciate it! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, ash2k, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Only configure the local warning handler. Please see the issue for details.
Fixes #1928.