-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃摉 add comments for configuration #1992
馃摉 add comments for configuration #1992
Conversation
Welcome @Icarus9913! |
Hi @Icarus9913. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
reference : controller-runtime/pkg/manager/manager.go Lines 552 to 555 in 15b6689
|
pkg/manager/manager.go
Outdated
@@ -219,6 +219,7 @@ type Options struct { | |||
|
|||
// HealthProbeBindAddress is the TCP address that the controller should bind to | |||
// for serving health probes | |||
// It can be set to "0" or "" to disable the health serving. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// It can be set to "0" or "" to disable the health serving. | |
// It can be set to "0" or "" to disable serving the health probe. |
nit
Can you please add the same comment in:
HealthProbeBindAddress string `json:"healthProbeBindAddress,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already added
Signed-off-by: Icarus9913 <icaruswu66@qq.com>
57615e3
to
101a413
Compare
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, Icarus9913 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
add configuration comments once use
NewManager
Signed-off-by: Icarus9913 icaruswu66@qq.com