-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Allow to provide a custom lock interface to manager #2027
✨ Allow to provide a custom lock interface to manager #2027
Conversation
Welcome @johscheuer! |
Hi @johscheuer. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
var resourceLock resourcelock.Interface | ||
if options.LeaderElectionResourceLockInterface != nil && options.LeaderElection { | ||
resourceLock = options.LeaderElectionResourceLockInterface | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If options.LeaderElectionResourceLockInterface
is nil we will go into the else
clause even if options.LeaderElection
is false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah nvm, missed the fact that we only construct it her and whether or not we use it is determined elsewhere
var resourceLock resourcelock.Interface | ||
if options.LeaderElectionResourceLockInterface != nil && options.LeaderElection { | ||
resourceLock = options.LeaderElectionResourceLockInterface | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah nvm, missed the fact that we only construct it her and whether or not we use it is determined elsewhere
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, johscheuer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: #2026
This allows a more flexible configuration of the controller-runtime leader election if needed. Those changes allow to provide a custom
resourcelock.Interface
that will be used for leader election.