Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠ Add context to EventHandler(s) #2139

Merged
merged 1 commit into from
Jan 26, 2023
Merged

⚠ Add context to EventHandler(s) #2139

merged 1 commit into from
Jan 26, 2023

Commits on Jan 24, 2023

  1. Add context to EventHandler(s) 

    This changeset adds a context.Context parameter to every EventHandler
call. Most project might use MapFunc specifically to retrieve other
objects with clients and potentially enqueue requests to a watching
object. A context is useful in these cases to avoid using context.TODO()
or Background() which never gets cancelled.

Signed-off-by: Vince Prignano <vincepri@redhat.com>
    @vincepri
    vincepri committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    2464a9d View commit details
    Browse the repository at this point in the history