pkg/client/fake/client.go: get gvk without potential panic in List()

[estroz]

Unless opts.Raw.TypeMeta is explicitly populated, client.List() panics. As noted in #168, population is not necessary outside of the fake client. This simple fix does essentially the same thing as unstructuredClient.List().

Closes #168

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: estroz
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: directxman12

If they are not already assigned, you can assign the PR to them by writing /assign @directxman12 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[estroz]

Signed

[sverrirsig]

Thank you! - List() now works perfectly 👍

[grantr]

This is quite similar to #213. 😃

[estroz]

@grantr yes your solution looks better. I'll close this if @DirectXMan12 @droot give the ok.

[droot]

@estroz Thanks for submitting this fix. Took at a look at #213 which also addresses this issue and improves the code/tests also, so lets close this in favor of #213 .