Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ upgrade to k8s 0.27.1 #2189

Merged
merged 1 commit into from
May 3, 2023
Merged

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Feb 13, 2023

This PR moves k8s dependencies to 0.27.1 and reworks things to make the tests/linter happy.

k8s.io/apimachinery deprecated legacy Poll methods and this
triggers golangi-lint staticheck errors.

Rework all the poll logic to move to the preferred methods.

Details: kubernetes/apimachinery@831cf05

Additionally, NamespacedName type now implements MarshalLog() which
replaces the functionality in kube_helpers.go. See k/k #117238..

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 13, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @mythi!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 13, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @mythi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 13, 2023
@mythi mythi force-pushed the 27-upgrade branch 2 times, most recently from 99ee96b to dab6f18 Compare February 15, 2023 12:05
@mythi mythi changed the title WIP: ⚠️ upgrade to 0.27.0-alpha.1 ⚠️ upgrade to 0.27.0-alpha.2 Feb 15, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2023
@mythi mythi changed the title ⚠️ upgrade to 0.27.0-alpha.2 ⚠️ upgrade to k8s 0.27.0-alpha.2 Feb 15, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2023
@mythi mythi changed the title ⚠️ upgrade to k8s 0.27.0-alpha.2 ⚠️ upgrade to k8s 0.27.0-alpha.3 Mar 3, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2023
@howardjohn
Copy link
Contributor

I have an alternative PR that makes controller-runtime support 1.27 and 1.26 concurrently so projects do not need to serialize updates: #2223

I am also fine with this, just presenting an option. I would like to see some support for 1.27 merged ideally, though.

@mythi
Copy link
Contributor Author

mythi commented Mar 8, 2023

I have an alternative PR that makes controller-runtime support 1.27 and 1.26 concurrently so projects do not need to serialize updates: #2223

I am also fine with this, just presenting an option. I would like to see some support for 1.27 merged ideally, though.

I'm totally fine with the proposed alternative. My goal (this PR) was also to just get to 1.27...

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2023
@mythi mythi changed the title ⚠️ upgrade to k8s 0.27.0-alpha.3 ⚠️ upgrade to k8s 0.27.0-rc.0 Mar 30, 2023
@mythi
Copy link
Contributor Author

mythi commented Mar 30, 2023

I have an alternative PR that makes controller-runtime support 1.27 and 1.26 concurrently so projects do not need to serialize updates: #2223
I am also fine with this, just presenting an option. I would like to see some support for 1.27 merged ideally, though.

I'm totally fine with the proposed alternative. My goal (this PR) was also to just get to 1.27...

Rebased since #2223 is now merged.

@mythi
Copy link
Contributor Author

mythi commented Mar 30, 2023

@alvaroaleman @vincepri could I get ok-to-test to see tests are passing. make test was passing for me locally

@alvaroaleman
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 30, 2023
@sbueringer
Copy link
Member

lgtm from my side pending 0.27.2 and resolution of #2189 (comment) (let's wait for feedback there)

k8s.io/apimachinery deprecated legacy Poll methods and this
triggers golangi-lint staticheck errors.

Rework all the poll logic to move to the preferred methods.

Additionally, NamespacedName type no implements MarshalLog() which
replaces the functionality in kube_helpers.go. See k/k #117238.

Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
@sbueringer
Copy link
Member

@mythi Thank you very much for all your work on this!!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
@sbueringer
Copy link
Member

/assign @vincepri @alvaroaleman

Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, mythi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023
@vincepri
Copy link
Member

vincepri commented May 3, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2e57de7 into kubernetes-sigs:main May 3, 2023
@sbueringer
Copy link
Member

Please note that we are still waiting for v0.27.2 with the v0.15 release.

Follow-up issue: #2297

@mythi
Copy link
Contributor Author

mythi commented May 4, 2023

@mythi Thank you very much for all your work on this!!

no problem. Even if this PR turned out to be WAY bigger task than I originally planned, I don't mind since I believe it gives a good learning for the future as well: it's probably good to start pulling/testing k8s release candidates to ensure all is good ahead of the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants