Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Fakeclient: Fix status handling #2259

Merged
merged 1 commit into from
Apr 14, 2023

Commits on Apr 12, 2023

  1. ⚠️ Fakeclient: Fix status handling

    This change fixes the status handling of the fake status client by
    
    * Adding a new `WithStatusSubresource` option and pre-poluating it with
      all in-tree resources that have a status subresource
    * Making its `Update` and `Patch` not change the status of any such
      resource
    * Making its status client `Update` and `Patch` only change the status
      for any such resources
    * Making it error if `Status().{Update,Patch}` is called on a resource
      that isn't configured to have the status subresource
    
    Since this was completely broken before in that both non-status and
    status Update/Patch would always update everything and the status
    resources get pre-populated, this is a breaking change. Any test that
    relied on the previous behavior would pass incorrectly though, as it
    didn't match what the Kubernetes API does.
    alvaroaleman committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    0bff6fc View commit details
    Browse the repository at this point in the history