⚠ Remove metrics with high cardinality

[sbueringer]

This PR basically reverts the metrics introduced in #2217. In practice the cardinality of these metrics is too high when CR is used to communicate with a lot of different clusters (host x verb x histogram). So we shouldn't register them per default.

This PR also drops RequestLatency as:

1. The documented way to register it doesn't actually work
2. 1.17 was a while ago

[sbueringer]

/assign @alvaroaleman

[sbueringer]

/cherry-pick release-0.14

[k8s-infra-cherrypick-robot]

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-0.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-controller-runtime-apidiff	e69c853	link	false	/test pull-controller-runtime-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alvaroaleman,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-infra-cherrypick-robot]

@sbueringer: new pull request created: #2299

In response to this:

/cherry-pick release-0.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jonathan-innis]

@sbueringer I was just looking around at this. Though this was dropped from the default registration flow, I wonder if it still makes sense to have a mechanism for registering these metrics if you are using controller-runtime. At present, anyone who wants to get these kinds of metrics has to go hunt around for how to do it in the client-go code and then discover that controller-runtime used to implement this but doesn't anymore.

[sbueringer]

@jonathan-innis In general it would be great to have a mechanism for this. Unfortunately, today we have to register these metrics in an init func. (the register func in client-go uses once).

So I think if we want to make this configurable in controller-runtime (e.g. via manager options) we have to make changes to the Register func in client-go first

[jonathan-innis]

So I think if we want to make this configurable in controller-runtime (e.g. via manager options) we have to make changes to the Register func in client-go first

I could see us just adding the RegisterClientMetrics() call back. I'll put a PR up upstream. We are already thinking about this in https://github.com/awslabs/operatorpkg. I also think it would be really nice if we just parsed out all of URL rather than just showing the raw URL data (getting something like "group", "kind", "version", etc. in a structured format would be really nice)