馃悰 Fix fetching all LazyRESTMapper versions after fetching single version #2350
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tenstad The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @tenstad. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/M
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
| @@ -75,6 +75,12 @@ func (m *mapper) KindFor(resource schema.GroupVersionResource) (schema.GroupVers | |||
|
|
|||
| // KindsFor implements Mapper.KindsFor. | |||
| func (m *mapper) KindsFor(resource schema.GroupVersionResource) ([]schema.GroupVersionKind, error) { | |||
| if resource.Version == "" { | |||
| if err := m.addKnownGroupAndReload(resource.Group, resource.Version); err != nil { | |||
There was a problem hiding this comment.
Isn't this a bit over eager and removing the "lazy" aspect if we always reload as soon as we get a request without version?
There was a problem hiding this comment.
Yeah, can be a bit over eager, but is it possible to fetch less and at the same time return the complete list?
Or is this by design, and #2349 not actually a bug?
Resolves #2349