Draft: Test that an object is updatable after updating its status.

[berlin-ab]

Test fails at:

  [FAILED] Unexpected error:
      <*errors.StatusError | 0xc0005ac000>: 
      Operation cannot be fulfilled on nodes "node": object was modified
      {
          ErrStatus: {
              TypeMeta: {Kind: "", APIVersion: ""},
              ListMeta: {
                  SelfLink: "",
                  ResourceVersion: "",
                  Continue: "",
                  RemainingItemCount: nil,
              },
              Status: "Failure",
              Message: "Operation cannot be fulfilled on nodes \"node\": object was modified",
              Reason: "Conflict",
              Details: {Name: "node", Group: "", Kind: "nodes", UID: "", Causes: nil, RetryAfterSeconds: 0},
              Code: 409,
          },
      }
      
  occurred
  In [It] at: /Users/aberlin/workspace/controller-runtime/pkg/client/fake/client_test.go:1506 @ 09/09/23 20:52:18.056

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: berlin-ab
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @berlin-ab. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[berlin-ab]

/hold

This is just a proof of concept test and possible implementation. Please rework as you see fit.

[berlin-ab]

This test fails. The test below was double checking that the reverse order also works.

[berlin-ab]

I was looking for a cleaner way to do this, so maybe you can think of one. I don't like the distance between when we make the deep copy and when we need to handle the repercussions of doing so.

[berlin-ab]

I've pulled in the latest fixes for the fake client to test against my personal project. That how I ran against this current bug. After applying the fix in this PR, my local tests work as expected.

This PR is a proof of concept test and fix. Please rework it as you need to in order to incorporate it into the project.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.