Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Bump k8s deps to 1.27.7 #2558

Merged

Conversation

varshaprasad96
Copy link
Member

No description provided.

Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 23, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 23, 2023
@varshaprasad96 varshaprasad96 changed the title ✨ [Bump] Bump k8s deps to 1.27.7 ✨ Bump k8s deps to 1.27.7 Oct 23, 2023
@varshaprasad96
Copy link
Member Author

Investigating the failed test

@varshaprasad96
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2023
@varshaprasad96
Copy link
Member Author

/retest

@sbueringer
Copy link
Member

/lgtm
/approve

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2023
@sbueringer
Copy link
Member

/hold cancel

IIRC one of the usual flakes

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2023
@sbueringer
Copy link
Member

sbueringer commented Oct 23, 2023

/hold

Missed the additional commit. Not sure if we should keep it or not. I think it's just a flake that we had in the past. Maybe we should try to fix it on main instead/first if the test is just flaky on release-0.15.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2023
@varshaprasad96
Copy link
Member Author

varshaprasad96 commented Oct 23, 2023

@sbueringer This test was failing locally for me with a 5 sec timeout. But with 10 sec, it seems to pass.

➜  controller-runtime git:(bump/k8s-1.27.7) ✗ go test -race sigs.k8s.io/controller-runtime/pkg/internal/testing/process
ok  	sigs.k8s.io/controller-runtime/pkg/internal/testing/process	4.514s

If this is an expected flake, I would not want to increase the stop timeout any further

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2023
@sbueringer
Copy link
Member

/hold cancel

Let's see what Prow says

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2023
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9a0ec0f into kubernetes-sigs:release-0.15 Oct 23, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants