-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 CreateOrPatch fails to update status when creating object #2631
Conversation
Existing code would not update the status. Add new result value OperationResultCreatedStatus to account for this
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jfremy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @jfremy! |
Hi @jfremy. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The
CreateOrPatch
code directly exits after creating an object, it does not consider whether the status was modified or not.This means that any change made to the status will be discarded.
Since the code correctly takes care of the status in the resource update case, I’ve updated the code to also do it in the create code path. I’ve tried to re-use as much as possible the existing code.
I’ve introduced a new operation result value (
OperationResultCreatedStatus
to indicate an object was created and its status updated as well) but we might want to hold on that since that could create issues with existing users of the method and keep returning theOperationResultCreated
code to maintain backward compatibility.I also included a non regression test to validate the change is working as expected.
Fixes #2627