-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix nil
error when using BootstrapOptions.Host
#272
🐛 fix nil
error when using BootstrapOptions.Host
#272
Conversation
/assign @DirectXMan12 |
/test |
looks good. can you squash the commits together. (also /test won't work b/c we're not running PRs via prow yet :-/) |
ba32a92
to
6cb24d8
Compare
@DirectXMan12 - rebase is done. |
I can do it. Let me file a bug too. I've got an issue to switch to prow now (#276) so that I don't have to do it. |
filed a bug for the test flake too (#277) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, ichekrygin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment inline
pkg/webhook/bootstrap.go
Outdated
@@ -297,7 +297,7 @@ func (s *Server) validatingWHConfigs() (runtime.Object, error) { | |||
} | |||
|
|||
func (s *Server) admissionWebhook(path string, wh *admission.Webhook) (*admissionregistration.Webhook, error) { | |||
if wh.NamespaceSelector == nil && len(s.Service.Namespace) > 0 { | |||
if wh.NamespaceSelector == nil && (s.Service == nil || s.Service.Namespace == "") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't you want the opposite here? This seems to change the meaning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah.. right. fixing...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DirectXMan12 this should be fixed, PTAL.
Signed-off-by: ichekrygin <illya.chekrygin@gmail.com>
6cb24d8
to
01f78d9
Compare
/lgtm |
Fixes: #271