Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ adding ability to get a APIReader from the client. #273

Conversation

shawn-hurley
Copy link

Adding a new interface APIClient to expose as part of the client
a non-caching reader interface.

fixes #180
fixes #245

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 2, 2019
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shawn-hurley
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: droot

If they are not already assigned, you can assign the PR to them by writing /assign @droot in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shawn-hurley
Copy link
Author

I think this is probably the first step described in #180

I think the next step would be to talk about the return of the GetCache and/or change the name. I think we want the ability to get to the cache for adding event handlers and such, but maybe hiding/changing the reader interface? @droot thoughts?

Adding a new interface `APIClient` to expose as part of the client
a non caching reader interface.

fixes kubernetes-sigs#180
fixes kubernetes-sigs#245
@DirectXMan12
Copy link
Contributor

I don't like this being part of client -- it brings weird implications to how we implement client. I think it should probably just be exposed directly on the manager.

@shawn-hurley
Copy link
Author

I think that I agree with @DirectXMan12 I will close this PR and move this to the manager in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible race condition / inconsistency between CRUD operations Why DelegatingClient is needed?
3 participants